Repository navigation
fix: preserve barrels after consumer write failures - #6
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
During default barrel discovery, when writing a rewritten consumer fails, its original import stays on disk. The tracker marks that consumer as rewritten before the write, so cleanup can delete the barrel it still needs. Move that tracking step after rendering and writing succeed. The regression injects a write failure into a temporary project and verifies that the barrel survives, including when another consumer was rewritten successfully. Dry-run and check mode retain their existing predictions. All 186 tests, build, lint, formatting and installed-check passed on Node 24. The failure is injected at the filesystem call; the test does not depend on platform-specific file permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During default barrel discovery, when writing a rewritten consumer fails, its original import stays on disk. The tracker marks that consumer as rewritten before the write, so cleanup can delete the barrel it still needs.
Move that tracking step after rendering and writing succeed. The regression injects a write failure into a temporary project and verifies that the barrel survives, including when another consumer was rewritten successfully. Dry-run and check mode retain their existing predictions.
All 186 tests, build, lint, formatting and installed-check passed on Node 24. The failure is injected at the filesystem call; the test does not depend on platform-specific file permissions.